tibirna / qgit

Official git repository for QGit.
Other
174 stars 68 forks source link

Clicking on individual commit in file view does not open the commit #11

Closed t8m closed 6 years ago

t8m commented 6 years ago

On Fedora 25 with qgit 2.7 clicking on individual commit in the file view (in the list of changes on that file) does not open the commit. The window with Rev list is opened but the revision opened is still the original one that was displayed in the Rev list before and not the desired revision.

Also rightclick on the commit in the file view does not open the contextual menu. This seems to be related to the problem above as both these problems started to appear in the same time. It seems to be some kind of race condition as on 2.6 the commit usually opened but sometimes not. In 2.7 the commit is never opened.

tibirna commented 6 years ago

I don't have a Fedora machine at hand and my own tests can't reproduce this behaviour. I'll get back after trying this on the distro-compiled Fedora 25 package.

flok32 commented 6 years ago

I got the same issue after updating Xubuntu from 17.4 to 17.10

deveee commented 6 years ago

As said in the http://libre.tibirna.org/issues/48 it's because of https://github.com/tibirna/qgit/commit/2fed338fd4c8c9bf147beeca7018ff2a946dbfb3

For me in <2.7 it was always working...