FileHistory: Add "Short Hash" column.

[WickedSmoke]

This is a basic implementation for issue #118. The hash size is hardcoded to show 8 characters.

[tibirna]

Thank you very much for your very quick addition. Much appreciated. I made a small comment on the patch. Please let me know if you don't agree.

[WickedSmoke]

The patch has been updated to get the ideal length from Git. I stored shortHashLen in the Git class so that FileHistory did not become coupled to MainImpl. This does fix the execution error dialog mentioned above.

[tibirna]

Merged. Thank you very much for your contribution!

As is my custom, I added your name to the list of contributors. Thanks again!

Future improvement of this new feature would be, IMO:

• put the short SHA column in front of the shortlog column (to resemble more git output)
• make the short SHA column optionally hidden.

[WickedSmoke]

Heh, thanks for pulling, but you jumped the gun a bit. I was wondering if the column should be named "Commit", as this is the word used by the CLI program and a number of other GUIs.

[tibirna]

If you want to continue on this, please do. I'll wait your signal before re-merging.

[WickedSmoke]

I grouped the hash column with Author & Date to match the grouping in the CLI log and also place it near the hash QLineEdit so that the eye has to travel less when verifying that the list item and the line edit values match. Other GUIs do put Commit before the Short Log.

I'm not going to make the column optional as part of this patch. This can be done if someone else wants to make the lists columns fully configurable (both order & visibility).

[WickedSmoke]

If you agree that the column name should be "Commit" I'll do that and call it a day.

[tibirna]

I agree. Thanks again.

On Sun, 7 Nov 2021 at 12:04, WickedSmoke @.***> wrote:

If you agree that the column name should be "Commit" I'll do that and call it a day.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/tibirna/qgit/pull/119#issuecomment-962646154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJOWDTWH4JZGTBRWPRT35TUK2WSLANCNFSM5HQEYE2Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[WickedSmoke]

I overwrote my master commit with the column rename so please pull that.

[tibirna]

Done. Thanks.

[pwillard2]

I got zip file, and with this Commit change, I am seeing 2 columns with "Author Date". Apparently "Author" column has been renamed. I think you need to change the index in FileHistory::clear to use 5 instead of 4:

if (testFlag(REL_DATE_F)) { secs = QDateTime::currentDateTime().toTime_t(); headerInfo[5] = "Last Change"; } else { secs = 0; headerInfo[5] = "Author Date"; } rowCnt = revOrder.count(); annIdValid = false; endResetModel(); emit headerDataChanged(Qt::Horizontal, 0, 5);

[tibirna]

You are right, M. Willard. Thanks very much! I completely missed this.

It is fixed now at the top of master.

[WickedSmoke]

Those headerInfo indices should be using the ColumnType enums so they stay synced with future changes.

[tibirna]

@WickedSmoke you are absolutely right. Done. Thanks.