search

tibirna / qgit

Official git repository for QGit.
Other
171 stars 66 forks source link

Reduce compilation warnings #128

Open martenjj opened 1 year ago

martenjj commented 1 year ago

They do not affect the code, but give lots of diagnostic messages when compiled with -W -Wall -Wextra. The changes remove them so that other messages warning of potential problems will not be lost among the noise.

The wanings eliminated are: "declaration shadows a member" "use of old-style cast" "can be marked override" "declaration shadows a parameter" "declaration shadows a previous local" "implictly-declared (constructor) is deprecated"

tibirna commented 1 year ago

Hello Jonathan

For my instruction, please describe in some detail your compilation setup.

I have the latest gcc (gcc-12) available for my distro, I have the compiler debug flags set to -g -W -Wall -Wextra -pedantic and I don't see all the warnings you seem to see.

I can only see the warnings you fix with your last commit.

I can understand from the code the fixes in the 2nd and 3rd commit (although I would like to also get the warnings locally, so please help me with the config).

And I don't see any reasons in the code for the 1st and 4th commit.

Thanks in advance Cristian