search

tibirna / qgit

Official git repository for QGit.
Other
169 stars 65 forks source link

Possible to restore Qt4 compatibility? #138

Open barracuda156 opened 10 months ago

barracuda156 commented 10 months ago

We do not have Qt5+ on PowerPC, unfortunately. However, Qt4 works perfectly.

tibirna commented 10 months ago

Hello. Sorry for the late answer (grave family matters...).

There is a "compile_with_qt4" branch from back in 2014. You can compile that version with Qt4. Of course, you'll miss the few features added afterwards.

Theoretically, all commits added afterwards, which are not explicitly "fixing" compilation with Qt5, could be ported to the Qt4 branch. This is time intensive work, though, and I don't see who will embark into this, given that 99% of computers in the world that use Qt are using Qt5, and many are starting to use Qt6. Last version of Qt4 was published more than 12 years ago. I wonder if it isn't more beneficial to attempt compiling Qt5 on PowerPC (which would enable all the new apps based on this library).

Thanks for your understanding.

barracuda156 commented 10 months ago

@tibirna Thank you for responding! I have actually got 2.7 to build with Qt4, and it builds fine pretty much on every macOS: https://ports.macports.org/port/qgit/details (no build bot for PowerPC, but that I have confirmed locally). Anything still to borrow from compile_with_qt4 branch, or no point in that?

I did not try fixing later versions, no time so far, but perhaps some later commits could be backported.

tibirna commented 10 months ago

@barracuda156 no point in trying to borrow from compile_with_qt4, it's already completely contained in newer versions.

Thank you very much for the effort in backporting. If you don't mind a bit more work, please consider pushing a branch on top of 2.7 containing your changes that allow compiling with Qt4. Thus, all those interested will benefit from your generous time investment.

Thanks Cristian