search

tibirna / qgit

Official git repository for QGit.
Other
171 stars 66 forks source link

Add possibility to highlight all search results at once #143

Closed zkrx closed 5 months ago

zkrx commented 5 months ago

It would be great if the embedded patch viewer had the possibility to highlight all matches from a search (with ctrl + f).

Browsers have this feature, most editors do it as well. When reviewing patches, highlighting all search results is a necessity. You hit ctrl + F, enter your keyword and then just scroll to quickly see all matches. Unfortunately, qgit doesn't do it by default (it highlights one match at a time) and I wasn't able to find a setting to highlight all matches at once.

tibirna commented 5 months ago

Thanks for this request. It seems part of the work for this was done some time ago, but was not connected because of (at the time) slow performance on large patches. I mark this as an entry level issue.

zkrx commented 5 months ago

Wow that was very quick. I've just built and installed your latest release with cf3350e88cc8c8249385efac63ddf15ac1eff42a.patch applied and it seems to work fine. Thank you so much.

tibirna commented 5 months ago

Thank you for reporting the issue.