search

tibirna / qgit

Official git repository for QGit.
Other
174 stars 68 forks source link

Git hook output shown as errors irrespectively of the exit code #29

Open tibirna opened 6 years ago

tibirna commented 6 years ago

Submitted by Andrey Rahmatullin on 2016-03-27. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=791484

“"” I have a local pre-commit hook set up to run some stuff right before the actual commit. This works just fine when committing on the command-line. However, when I commit in QGit, it pops up a message saying that there was an error committing and showing the output of the pre-commit hook. There was no error, the exit code of everything is 0 when I run this on the CLI. QGit should thus not say anything about errors, and it should re-load the commit log to show the new commit. “"”

filiperinaldi commented 6 years ago

Just to clarify, qgit seems to think there is an error when the hook prints out something.

filiperinaldi commented 6 years ago

Ok, looking further, it is actually intentional that QGit does not look only into the exit code, but also on the stderr. In this case, I believe the user's git hook was printing debug/info on the stderr. Perhaps qgit could be more helpful and say something like "...the command succeeded, but output the following message on the stderr...".