search

tibirna / qgit

Official git repository for QGit.
Other
175 stars 68 forks source link

Big gap between the reference labels and the commit title #51

Closed filiperinaldi closed 6 years ago

filiperinaldi commented 6 years ago

There is a big gap between the ref names and the text following them in the 'Rev list' view under MacOS. See screenshot:

screen shot 2018-08-13 at 14 25 46

It works fine (no gap) when running QGit in debug mode. But in this case, the fonts are very pixelated.

mwoehlke commented 6 years ago

This seems to be a HighDPI issue. I've noticed it also on Linux, on a system with display scaling == 2. It's fine on a different machine that is almost the same software but not HighDPI.

(I'm virtually certain that the width to allow is being computed in actual pixels, but applied in virtual pixels.)

filiperinaldi commented 6 years ago

Yes, the problem is in ListViewDelegate::paintLog(). The screenshot does not show, but when there are multiple markers on the same commit (tags, branches, etc) then they have compounding gaps. For this, the problem is in ListViewDelegate::addTextPixmap().

I have a fix now for both issues (I just need to clean-up and put back the conditionals QT5 flags before sending a PR): https://github.com/filiperinaldi/qgit/commit/c5cf6d0135a0ca30a050318051898d5580fdf643.