Properly handle GPG signatures in log, fix git version comparisons.

[jaakristioja]

This fixes #66 and incorrect git version comparisons in src/git.cpp.

[tibirna]

Commit https://github.com/tibirna/qgit/pull/70/commits/ae562871fcb08 :

• Error message when git version can't be parsed by the regex should read "Unexpected" instead of "Incorrect"
• gitVersionCompare should not trigger overall program failure as if git version was incompatible when versions can't be parsed with defined regex, because git developers can decide unexpectedly to change their version numbering scheme in the future (or locally modified copies of git can be used, with non-compliant version numbering). A fallback should be added, that simply compares string equality or lexicographical order (care must be paid in this later case, to avoid issuing incorrect return, e.g. when comparing lexicographically 3.1.0 and 3.1.0-dev -- such cases can be signaled as incompatibilities, though)
• instead of -1, 0, 1 returns from gitVersionCompare, prefer adding an enum {INCOMPATIBLE = 0, COMPATIBLE) and use that as return code(this will greatly increase code readability)

[tibirna]

Commit https://github.com/tibirna/qgit/pull/70/commits/d315fd45afd6 :

• qgit should display a message in the console (and perhaps in its status bar) when it ignores gpg signatures.

[tibirna]

Thank you very much for having taken the time to address #66.

I apologize for the long time I took for revising this. Please consider my comments and let me know. I will process your pull request immediately after.

[jaakristioja]

Sorry for the very long delay. To be honest, I stopped using qgit because I've learnt that the git command-line interface is actually sufficient for things I previously used qgit for (most importantly for visual graphs, e.g. git log --oneline --decorate --graph --no-show-signature --date-order --remotes --branches --tags). This means I'm no longer interested in pursuing this. I am sorry. I release my code in this pull request as public domain, no attribution required.

Note that commit https://github.com/tibirna/qgit/commit/ae562871fcb08 is not strictly required to fix #66, but is a different issue. Given that the git developers might not follow a strict versioning scheme, https://github.com/tibirna/qgit/commit/ae562871fcb08 might indeed not be enough.

As for gitVersionCompare() returning -1, 0 or 1, I tried to follow the logic of strcmp() and similar functions (including the <=> operator in C++20). If gitVersionCompare() is only to be used to compare against GIT_VERSION_REQUIRED, then perhaps it would make sense to refactor it into a bool isGitVersionCompatible(QString const &) function instead.

Regarding commit https://github.com/tibirna/qgit/commit/d315fd45afd6, I think that displaying a message for this would not provide any extra value, because you are already ignoring them if log.showSignature is not true in the git configuration. As opposed to --no-verify-signatures (as for git pull), passing --no-show-signature to git is just part of some background processing.

I hope this helps.

[tibirna]

Thank you very much for the detailed and thoroughly helpful rundown of your contribution. It is wholeheartedly appreciated.

With your accord, I will take at some point your branch, adapt it based on my observations and your clarifications, and included in the base qgit code.

Thanks again and great success in your future endeavors.

[jaakristioja]

Thank you very much! Same to you! :smiley: