search

tibirna / qgit

Official git repository for QGit.
Other
175 stars 68 forks source link

Clicking on a file's version history doesn't show the associated revision #82

Open andrewgin opened 4 years ago

andrewgin commented 4 years ago

Hi I think this is a problem with my setup rather than a bug, but I don't know how to diagnose the issue;

  1. Click on a commit in the Rev list tab
  2. In the bottom right pane, it will show the list of files modified in this commit. Double click on a file to show the patch tab.
  3. Double click on the file again to open the file history tab.
  4. The top pane shows the commits that have modified this file, the bottom pane shows the entire file for that revision.
  5. Clicking on a different commit doesn't change the revision of that file; it shows the revision from the commit clicked in step 1.

This used to work, but then I upgraded my ubuntu to 18.04.2

andrewgin commented 4 years ago

My colleague just testedit on 18.04.3 and has the same issue.

kfessel commented 1 year ago

this is behavior change in git. when a file is clicked a git log containing the parameter -m is is run

git log --topo-order --no-color --log-size --parents --boundary -z \
'--pretty=format:%m%HX%PX%n%cn<%ce>%n%an<%ae>%n%at%n%s%n' \
-r -m -p --full-index <some commit hashes> <Filename>

that -m changed its behavior between git 2.30 and 2.39 multiple time see

https://www.git-scm.com/docs/git-log/2.30.0#Documentation/git-log.txt--m

https://www.git-scm.com/docs/git-log/2.39.0#Documentation/git-log.txt--m

i hope this helps fixing this

https://github.com/tibirna/qgit/blob/6e95bf4d8ad85645986ba94aaa04a115a9dcc010/src/git.cpp#L2194