Closed muffato closed 4 years ago
Oh, actually I've just realised I've been mixing several bugs.
I can see three bugs:
From the git history, it doesn't seem you maintain older branches such as 2.8, so I will try to find a solution for the bugs n°2 and 3 on master. If you've got any pointer, that would help :)
Regards, Matthieu
Platform information
It's a Dell XPS laptop running the stock Kubuntu with the KDE backports. My laptop screen is 3200x1800 which I scale 1.5x in the System Settings.
Problem
qgit shows a gap between the tag / branch labels and the log message:![Screenshot_20200206_235056](https://user-images.githubusercontent.com/623458/73988856-dbef1b80-493b-11ea-8610-7ad179d3659b.png)
The gap looked to about half the size of the label, so I got the idea it was linked to the scaling factor
Proposed solution
I think because
but ...
pixmapSize
above already takes the device pixel ratio into account we don't need to set it again onnewPm
. This seems to work on my laptop:Next problem
If you look closely you will see that the labels look less sharp with my "fix". If you look at the green box for master, it's about 80px wide in my screenshots, and it feels like the text has now been generated at a smaller resolution, and probably up-scaled 1.5x.
What do you think ? I'll try to play with the various size variables if I can find another fix.
Regards, Matthieu