search

tibirna / qgit

Official git repository for QGit.
Other
175 stars 68 forks source link

Running latest qgit on Mac OS X 10.6.8 has memory leaks #89

Open NucleaPeon opened 4 years ago

NucleaPeon commented 4 years ago

When running qgit on the command line on snow leopard, I get these messages:

qgit-mem-leak

Applying the CocoaInitializer fix results in no error messages:

prevent-mem-leaks

You can find the fixes in my forked repo: https://github.com/NucleaPeon/qgit

I built qgit using Qt 5.3.2.

Thanks for building/maintaining this piece of software.

tibirna commented 4 years ago

Hello Dan

Thank you very much for this contribution. It is very much appreciated, in particular given that I don't have access to a MacOS machine for development so your help is very useful.

Please consider making a pull request so that I can merge your changes in the main qgit repo.

Thanks Cristian

NucleaPeon commented 4 years ago

I made a pull request, but this is the first time doing so on github. Let me know if I need to take additional steps. I squashed it into one commit and put it in a branch.

https://github.com/NucleaPeon/qgit/tree/macosx-10.6.8-memleak-fix

NucleaPeon commented 4 years ago

I'd hold off merging it just yet, there's an issue with some of the main menu being duplicated.

NucleaPeon commented 4 years ago

OK ready for merge

tibirna commented 4 years ago

Your pull request didn't work (I can't see it in my list). From what I can tell, you made against your repository.

When generating the pull request, choose the base repo to be tibirna/qgit.

NucleaPeon commented 4 years ago

Sorry, I'm unfamiliar with github's workflow. I've forked directly from you and patched in the changes into their own branch. https://github.com/tibirna/qgit/pull/91

Thank you