tibirna / qgit

Official git repository for QGit.
Other
175 stars 68 forks source link

Adding in cocoainitializer class to prevent mem leaks on Cocoa-based Macs #91

Open NucleaPeon opened 4 years ago

NucleaPeon commented 4 years ago
tibirna commented 4 years ago

What is the license on the cocoainitializer.{h,mm} files? Headers indicate authors other than you.

NucleaPeon commented 4 years ago

Sharp eye. I pulled the code from https://github.com/torrent-file-editor/torrent-file-editor. License file reports GPL 3.0 https://github.com/torrent-file-editor/torrent-file-editor/blob/master/LICENSE

Edit (clarification)

I didn't write it, I left in the previous authors. I attempted to find a fix for the same issue on a project I'm working on. In an obscure mailing list, I found a reference to CocoaInitializer. Searching for it, I found a github result that had those two files in it. I'm not sure if the repo owners wrote it themselves, but information was sparse and it fixed my issue.

The QT developers dismissed the NS pool memory autorelease issue, saying 5.3.1/2 was no longer going to be supported for snow leopard going forward and I haven't seen the issue on much later versions of OS X (10.11)

filiperinaldi commented 2 years ago

I haven't seen the issue on much later versions of OS X

I suppose this PR is no longer relevant then?