search

tibirna / qgit

Official git repository for QGit.
Other
175 stars 68 forks source link

Git says "Under Linux, use ExitStatus to determine whether an external command failed" #95

Closed brentr closed 4 years ago

brentr commented 4 years ago

I'm a long time qgit fan. Thank you for producing this wonderful, cross-platform, git GUI. MyProcess::on_finished() has a comment that suggests that git status under Linux returns with a non-zero exit code when there is no error, and, that is why you resort read stderr to determine if a command failed. My own tests, under Linux, show that "git status" returns with exit code 0. I would suggest that you could resort to the STDERR hack only when the host OS is not Unix derived.

tibirna commented 4 years ago

Thanks for the good comments and for the suggestion. I will look into it.

(Any patches appreciated :-)

tibirna commented 4 years ago

Patch merged. Thanks!