I discovered that git config commands qgit invokes do return non-zero exit status.
But, fortunately, in these cases, nothing gets written to stderr.
So, the logic is, if not running windows, produce the command failed dialog only if
exit code != 0 AND not stderr.empty
I also removed the "Git says:" from the generic command failed dialog text because such commands may not invoke git. In this case, saying "Git says" will be very misleading.
I discovered that git config commands qgit invokes do return non-zero exit status. But, fortunately, in these cases, nothing gets written to stderr. So, the logic is, if not running windows, produce the command failed dialog only if exit code != 0 AND not stderr.empty
I also removed the "Git says:" from the generic command failed dialog text because such commands may not invoke git. In this case, saying "Git says" will be very misleading.