tibirna / qgit

Official git repository for QGit.
Other
174 stars 68 forks source link

Make Settings dialog accessible on macOS #97

Closed mvf closed 4 years ago

mvf commented 4 years ago

The Settings dialog was inaccessible on macOS because its menu item was being removed by Qt's menu role heuristic, and the Setup actions menu item took its place.

Edit: Amended to now also prevent suitably named custom actions from suffering the same fate as Setup actions.

Some screenshots to illustrate the problem and the solution.

Before

No Settings item in the Edit Menu (expected), Actions menu missing when there are no actions:

bad_editmenu

The Preferences item in the application menu is actually the Setup actions item, only betrayed by its icon:

bad_appmenu

After

Settings appears as Preferences in the application menu:

good_appmenu

Setup actions is back in Actions where it belongs:

good_actionsmenu