tibo-mllr / activeviam-projet

1 stars 0 forks source link

Create React app #11

Closed tibo-mllr closed 2 weeks ago

tibo-mllr commented 2 weeks ago

Create and setup a React app using Next.js

Will fix:

tibo-mllr commented 2 weeks ago

Open to any changes in ESLint or prettier rules ! @TimotheeVrg @AlexandreCGithub @carlrizk

tibo-mllr commented 2 weeks ago

Now also fixes #2 and #4

tibo-mllr commented 2 weeks ago

Should I also update eslint to latest Major version @carlrizk ? The mandatory flat config usually makes me sick, but here it's a small project for the moment so I can try

carlrizk commented 2 weeks ago

Should I also update eslint to latest Major version @carlrizk ? The mandatory flat config usually makes me sick, but here it's a small project for the moment so I can try

Yes, if you think its a good improvement to do. You and your team are owner of the code and can do whatever you feel is better for your project.

tibo-mllr commented 2 weeks ago

What do you think @TimotheeVrg @AlexandreCGithub ? I suggest we stay on version 8, else we also have to re-configure the extension, that doesn't allow flat config by default and doesn't look for the new name of the file.

AlexandreCGithub commented 2 weeks ago

Everything seems good to me. Ok for version 8

TimotheeVrg commented 2 weeks ago

Seems fine to me (for eslint, prettier rules and everything else), I'll approve too!