search

tibordp / prefer-dual-stack-webhook

Admission controller that makes services dual-stack by default
Apache License 2.0
8 stars 0 forks source link

Bug: When handling ExternalName services it should not touch IpFamilyPolicy #2

Closed samip5 closed 3 years ago

samip5 commented 3 years ago

I noticed that if I have an ExternalName service, the mutating webhook tries to do ipFamilyPolicy which is not allowed.

apiVersion: v1
kind: Service
metadata:
  name: gitlab-docker
  namespace: networking
spec:
  ports:
    - name: https
      port: 443
  type: ExternalName
  externalName: 192.168.2.33
The Service "gitlab-docker" is invalid: spec.ipFamilyPolicy: Forbidden: may not be set for ExternalName services