search

tibotiber / rfd-animate-example

D3 animate example for React-Faux-DOM
2 stars 1 forks source link

Zero tick missed #2

Open snarknn opened 6 years ago

snarknn commented 6 years ago

Hi tibotiber!

I've found the issue in my pull request I've sent to you few days ago. As you can see, there is no zero tick displayed on the diagram. But it was displayed in your version with d3 v3. I've tried to find why this happens, but no success yet, probably my knowledge of d3/react/react-faux-dom is not enough. I'm almost sure (but not 100%) this is not d3 issue, because when I rewrite this on clean d3 all works well.

Probably you can help me with that issue, or redirect me to right person?

Thanks in advance, Ilya

Olical commented 6 years ago

So if I had to guess, it'll be due to the upgrade to d3 v4. It seems like a lot of people are using it, but I have never tried it. RFD was built with v3 in mind, there may have been changes to what DOM APIs it requires.