tibudiyanto / jakarta-vax-availability

jakarta-vax-availability.vercel.app
100 stars 46 forks source link

feat: add gmaps route direction #19

Closed juaan closed 3 years ago

juaan commented 3 years ago

Summary

add Lihat Rute button in VaxLocation, I used namaLokasi instead of lat and lon, because when I used lat and lon, the place is different in gmaps

Preview Video

https://user-images.githubusercontent.com/20969634/124467236-c9dc0b80-ddc1-11eb-9fb2-165e233ad4e5.mov

vercel[bot] commented 3 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @tibudiyanto on Vercel.

@tibudiyanto first needs to authorize it.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tibudiyanto/jakarta-vax-availability/BaDPqZtKtFCPTtWki5XF3Hgghy3r
✅ Preview: https://jakarta-vax-availability-git-fork-juaan-feat-2644b0-tibudiyanto.vercel.app

pveyes commented 3 years ago

this is duplicate from #7 right? cc @angeloanan does lat/lon works in your PR? Personally I prefer to use lat/lon as it's more consistent than search keyword

also this might affect #25

angeloanan commented 3 years ago

PR #7 uses lat/lon on Google Maps search which will direct user to a dropped pin on the said location. If the API doesn't provide any lat/lon, the link will resolve to a search for the vaccination site's name instead.

tibudiyanto commented 3 years ago

i too prefer lat lon then search

juaan commented 3 years ago

Ah I see, I think we can use https://github.com/tibudiyanto/jakarta-vax-availability/pull/7, and we can close this PR, thank you guys!

resir014 commented 3 years ago

Superseded by #7.