tibudiyanto / jakarta-vax-availability

jakarta-vax-availability.vercel.app
100 stars 46 forks source link

Add runtime type validation using runtypes #47

Closed broerjuang closed 3 years ago

broerjuang commented 3 years ago

I add runtypes to documenting what is returned to API. So maybe it helps.

vercel[bot] commented 3 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @tibudiyanto on Vercel.

@tibudiyanto first needs to authorize it.

pveyes commented 3 years ago

cc-ing @resir014 as it's related to #26

resir014 commented 3 years ago

@broerjuang @pveyes Let's wait until #34 is merged, since that's the farthest we have with the types. We can focus this PR solely on runtypes validation.

broerjuang commented 3 years ago

@resir014 been rebased it to master and adding just runtypes to this PR.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tibudiyanto/jakarta-vax-availability/5DreooLE5mmeWMvfg9eUQ5VEa9wA
✅ Preview: Failed

resir014 commented 3 years ago

@broerjuang ESLint errors, please fix.

pveyes commented 3 years ago

sorry can you wait for #61 & rebase afterwards 🙇

broerjuang commented 3 years ago

rebase it already, and change jakiKuota to string. Since the value still returned from the server. 🙇