Closed syauqy closed 3 years ago
Someone is attempting to deploy a commit to a Personal Account owned by @tibudiyanto on Vercel.
@tibudiyanto first needs to authorize it.
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/tibudiyanto/jakarta-vax-availability/72i2rKoz8wHKZa57rgd2LLiPwK82
✅ Preview: https://jakarta-vax-availability-git-fork-syauqy-main-tibudiyanto.vercel.app
Thank you for the review @resir014.
Lihat Lokasi
flex block on VaxLocation
to VaxLocationDetail
?
And since the schedules are inside the drawer, can we remove the schedule button and popover at VaxLocation
card?I'm not really sure about the green color, is it too bright? Also, what do you think of the table size? is it too tight and small? For the comparison, this is "md" table size.
And since the schedules are inside the drawer, can we remove the schedule button and popover at VaxLocation card?
@syauqy These are still needed in the map page. Either keep it, or add a prop to VaxLocationDetail
to toggle its visibility on e.g. the map page.
Also, the drawer should be moved to VaxLocation
since it's not needed in the map page. Everything inside VaxLocationDetail
is also rendered on the map page.
I'm not really sure about the green color, is it too bright?
These are fine. Remember that you can also use useColorModeValue(lightColor, darkColor)
hook to use different colours on light/dark mode.
Also, what do you think of the table size? is it too tight and small?
Let's keep it as it is.
@resir014
sure, the drawer moved to VaxLocation
and I keep the popover.
Remember that you can also use useColorModeValue(lightColor, darkColor) hook to use different colours on light/dark mode.
Ahh I see, this is helpful. thanks.
I pushed a new commit at https://github.com/tibudiyanto/jakarta-vax-availability/pull/79/commits/4a51660f6dd75333a5b326a6e500973531796c85
I add a drawer to view the vax location detail and vax schedule easier, esp. on the mobile view. Maybe with this addition, we can clean up some information on the front page.