search

ticgal / one-timesecret

A One-Time Secret integration with GLPI
https://tic.gal/en/project/a-one-time-secret-integration-share-your-passwords-securely/
GNU Affero General Public License v3.0
3 stars 4 forks source link

onetimesecret.com hardcoded #4

Closed vemi2709 closed 2 years ago

vemi2709 commented 2 years ago

https://github.com/ticgal/one-timesecret/issues/4

Hi, seems like onetimesecret.com is hardcoded in secret.class.php, we can't use our own One-Time Secret installation. -VeM-


Created by vemi2709

GLPI ticket number: 7780
Created with GitSync in GLPI by Óscar Beiro
OscarBeiro commented 2 years ago

You are right. Thanks for reporting it.

OscarBeiro commented 2 years ago

Could you please confirm that this patch fixes the issue? https://github.com/ticgal/one-timesecret/commit/a4d7256fddbe609e1a01650f188343bc66b2447d Thanks

vemi2709 commented 2 years ago

There must be something wrong with our own installation, the plugin works now when we use onetimesecret.com as the address. We investigate the matter a little bit more.

vemi2709 commented 2 years ago

Now it works, it was once again about certificates :)

OscarBeiro commented 2 years ago

Yep, we had that same issue with the onetimesecret.com. Certificates can be tricky. Thanks for the feedback.