Overhaul - Githubissues

ticketmaster-api / sdk-javascript

13 stars 5 forks source link

Closed oliverturner closed 8 years ago

oliverturner commented 8 years ago

Webpack 2, Babel, ES6, re-architected data types, refactored Page class, more tests, small demo showing the fluent interface.

adammeghji commented 8 years ago

@oliverturner LGTM -- thanks for these amazing contributions! Ready to merge in it's present state?

oliverturner commented 8 years ago

@adammeghji I think it is! One concern though: the Commerce API seems to require a channel id? Means I can't do any integration tests right now...

Other than that I think we're good to go :)

adammeghji commented 8 years ago

@oliverturner w.r.t. the Channel ID, might be a question best for @evohollywood.

Meanwhile, I'll merge this awesome body of work -- thanks again!