search

ticketmaster-api / sdk-javascript

13 stars 5 forks source link

Checks if _embedded obj exist to avoid error #7

Closed KomendaP closed 8 years ago

adammeghji commented 8 years ago

Looks good to me, thanks for the contribution :) I'll merge this, but curious to know, what request is returning a 200 OK response with no embedded events? Is this when your search doesn't match any results?

Perhaps this is an opportunity to harden the server as well in certain edge cases. LMK!

KomendaP commented 8 years ago

Hi! I think yes (if doesn't match any result). I had such problem during TM slack bot development. Thanks.

2016-06-30 23:30 GMT+03:00 Adam Meghji notifications@github.com:

Looks good to me, thanks for the contribution :) I'll merge this, but curious to know, what request is returning a 200 OK response with no embedded events? Is this when your search doesn't match any results?

Perhaps this is an opportunity to harden the server as well in certain edge cases. LMK!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ticketmaster-api/sdk-javascript/pull/7#issuecomment-229779639, or mute the thread https://github.com/notifications/unsubscribe/AIxbjAQ4z4uHDVhEZePP5M3DroidAUQUks5qRCdjgaJpZM4JB49h .

З повагою, Павло Комеда тел. +38(093)68-86-002

adammeghji commented 8 years ago

Cool, good to know. Can you send me a sample request? On Thu, Jun 30, 2016 at 17:56 Павло notifications@github.com wrote:

Hi! I think yes (if doesn't match any result). I had such problem during TM slack bot development. Thanks.

2016-06-30 23:30 GMT+03:00 Adam Meghji notifications@github.com:

Looks good to me, thanks for the contribution :) I'll merge this, but curious to know, what request is returning a 200 OK response with no embedded events? Is this when your search doesn't match any results?

Perhaps this is an opportunity to harden the server as well in certain edge cases. LMK!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/ticketmaster-api/sdk-javascript/pull/7#issuecomment-229779639 , or mute the thread < https://github.com/notifications/unsubscribe/AIxbjAQ4z4uHDVhEZePP5M3DroidAUQUks5qRCdjgaJpZM4JB49h

.

З повагою, Павло Комеда тел. +38(093)68-86-002

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/ticketmaster-api/sdk-javascript/pull/7#issuecomment-229800437, or mute the thread https://github.com/notifications/unsubscribe/AAimCUIq6XkP22x35k55Ra-DWt03dyrlks5qRDt5gaJpZM4JB49h .