Closed devblackops closed 8 years ago
I think it would be a good addition.
I got a head start on this
What needs to happen for PR #15 to be completed that implements this?
I need @beaudryj to resubmit it with just the one change. Right now the PR contains a bunch of old changes that are causing a conflict.
I have been slacking real hard, I'll try to get that in. Sorry Brandon On Tue, Aug 2, 2016 at 7:48 PM Chris Hunt notifications@github.com wrote:
I need @beaudryj https://github.com/beaudryj to resubmit it with just the one change. Right now the PR contains a bunch of old changes that are causing a conflict.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Ticketmaster/poshspec/issues/14#issuecomment-237085494, or mute the thread https://github.com/notifications/unsubscribe-auth/ACgvXPUjMn4AV0eZe5V_vy1EXgnslM00ks5qb9c4gaJpZM4I5Eqw .
[cracks whip] @beaudryj :smile:
Should this issue be closed by #30?
Yup. Thanks, @devblackops and @michaeltlombardi .
I'm thinking a new test for volumes would be useful. If people agree I'll create a PR implementing it.