ticketmaster / react-native-ticketmaster-ignite

MIT License
3 stars 0 forks source link

Android SDK bump causes dependency conflict with expo updates #40

Open gbradybulls opened 3 days ago

gbradybulls commented 3 days ago

The recent Android SDK bump introduces a dependency on com.ticketmaster.accounts:authentication:3.8.0, which has a transitive dependency org.bouncycastle:bcpkix-jdk15on:1.70, which in turn depends on org.bouncycastle:bcprov-jdk15on:1.70 and org.bouncycastle:bcutil-jdk15on:1.70

Unfortunately, this breaks compatibility with expo/expo updates. The expo updates module has dependencies for org.bouncycastle:bcprov-jdk15to18:1.70 and org.bouncycastle:bcutil-jdk15to18:1.70

Trying to compile then results in numerous Duplicate class errors, as the jdk15on and jdk15to18 versions of these libraries can't coexist in the same project

I've tried excluding the jdk15on versions of these deps, but it results in an instant crash (which I assume indicicates there are at least some API differences between the older jdk15on versions and the newer jdk15to18 versions)

Currently, the only thing I can do to fix our build is use dependencySubstitution to specify com.ticketmaster.accounts:authentication:3.6.0 and com.ticketmaster.tickets:tickets:3.6.0 in our build, which obviously has big drawbacks. Those are the most recent versions that don't have the org.bouncycastle:bcpkix-jdk15on:1.70 dependency, as far as I can tell.

Is there any chance com.ticketmaster.accounts:authentication might be updated to use the newer jdk15to18 version of org.bouncycastle:bcpkix?

Given the popularity of Expo / Expo Updates, I imagine this is an issue that will impact a lot of projects.

Thanks!

joe-goodall-ticketmaster commented 1 day ago

Hi @gbradybulls Thanks for bringing this up. We're looking into this our side. Will give you an update asap.