Feature external share

[soapdog]

Implements sharing as described in our sprint 4 plan for the week:

• Implements internal sharing with and without caption #117
• Implements external sharing with copying to the clipboard or opening the URL #117

ATTENTION: Even though implemented as per the documentation of Electron for shell.openExternal(), the opening of external URLs is not working on my windows machine. I'd like confirmation if it works elsewhere.

[mixmix]

Review

lots of little notes sorry - I'm doing this review at the end of the day while Ziva is getting grumpy. Looks like you've done some rad work with this. Haven't had a chance to spin it up and try it yet.

I think there a few tweaks needed and perhaps some minor things to extract into a module. Can discuss tmrw

[mixmix]

hey @soapdog you said you wanted to get some other things sorted before I merged this. Update?

[mixmix]

Trying the features on what's here already.

• the reshare could do with a couple of tweaks IMO

• this link isn't loading share2.ticktack.im:8807/%3JeEg7voZF4aplk9xCEAfhFOx+zocbKhgstzvfD3G8w=.sha256 (server timing out?)

  • the share1 equivalent loaded the message but the blog body was not present:

[mixmix]

There might be a gotcha with the pubs where we need to get them to "want" (the sbot command for blob fetching) the blobs of anyone they follow, so that they can reliably reshare

[mixmix]

The share messages both look well formed to me! They show up well in the counts, which is cool. At the moment there's no way or place to see re-shares text or that shares effect discovery feed right? Now that I think about it this is an obvious thing that needs design, but wasn't scoped. I wouldn't worry about it now but we should aim to do it in future work I think

I actually think this would be an awesome module that might benefit the scuttlebutts

[mixmix]

I think I probably need to know how to manage the new pubs that you've set up so we have redundancy

• ticktack-sgn : :heavy_check_mark: running
• ticktack2 : :fire: has had some sort of crash 2 hours ago (before I woke up)

[mixmix]

Just looking over the designs, I saw this. I think de-emphasising the buttons at the top and making clear buttons at the bottom is a good idea

If you don't want to do this in this PR I reckon start another issue for this?

[ticktackim]

@mixmix Yes, I am keen to this type. BTW, please note below is the first prototype, and the icon in final version is a little different.

原始邮件 发件人:mix irvingnotifications@github.com 收件人:ticktackim/ticktack-workplanticktack-workplan@noreply.github.com 抄送:Subscribedsubscribed@noreply.github.com 发送时间:2018年4月27日(周五) 08:14 主题:Re: [ticktackim/ticktack-workplan] Feature external share (#134)

Just looking over the designs, I saw this. I think de-emphasising the buttons at the top and making clear buttons at the bottom is a good idea If you don't want to do this in this PR I reckon start another issue for this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[soapdog]

@mixmix Working more on this tomorrow. I will work on this before you wake up again

There are two issues at hand:

• [ ] pubs crashing
• [ ] needs styling for share modals

[mixmix]

@soapdog I'm happy to call in @ahdinosaur in to help if that's a better user of time with the docket pubs

[soapdog]

@mixmix I've just exchange messages with Arj on a ssb-viewer issue I opened and learned that the branch we're using (which I patched) is no longer current and master has the useful bits now. It might be good to call upon @ahdinosaur to finish the pub work. Don't know if you'd like him to update the viewer as well.

[soapdog]

It is looking like this now.

[mixmix]

hey @soapdog remember to merge master in before doing some work. Looks like it's not a major conflict ...

[mixmix]

I've added some tweaks and am going to go ahead and merge this because it's been outside master too long I think, which I feel nervous about.

---

Note that still missing are these changes :

[mixmix]

There's a lot of details for this one, Nicely done @soapdog