search

ticofab / android-gpx-parser

A library to parse XML Gpx files, built for Android.
Apache License 2.0
123 stars 44 forks source link

Migrate to Kotlin #24

Closed ticofab closed 3 years ago

msbit commented 3 years ago

With this guy, how did you see this going?

I've put together https://github.com/msbit/android-gpx-parser/tree/kotlin, which is pretty much a straight conversion (with a bunch of Kotlin idioms thrown in). The only contentious bit would be the changes made as part of https://github.com/msbit/android-gpx-parser/tree/pre-kotlin, basically adding getters to the nested Builders so the same pattern could ~translate to Kotlin.

msbit commented 3 years ago

Actually, I'll put together a PR and we can go over that there :)

ticofab commented 3 years ago

I came to the conclusion that as long as Android & Kotlin guarantee full Java support and interoperability, it is wiser not to change everything only for the sake of it and the operation only poses risks and no concrete advantages. Thanks for the energy you put in this @msbit , I truly appreciate it and I hope you will understand my reasoning.