search

tidalcycles / Dirt

Experimental sample playback
GNU General Public License v3.0
85 stars 24 forks source link

command line option for gain, gain comp for shape #41

Closed bgold-cosmos closed 8 years ago

bgold-cosmos commented 9 years ago

I added a command line option “-g, —gain” to change the overall gain of Dirt when starting it up. This applies regardless of whether the dirty compression is turned on or off. It should default to the old values. The argument is given in dB from peak.

I also included some gain compensation for the “shape” parameter, so the distortion doesn’t just increase the loudness. The compensation is based on “typical” sounds, so results may vary, and it breaks down when the shape parameter is near 1.

Finally, I made a small fix to server.c to avoid message spam when Dirt receives extra OSC params.

calumgunn commented 9 years ago

All looks good to me! Nice :)

yaxu commented 9 years ago

Looks good! A little bit worried about the shape parameter change, a good idea but will change old patterns where people have compensated for the shape gain.. Should this be a commandline option too (with the new gain compensation being defaulted to on?) Or am I worrying too much?

kindohm commented 9 years ago

Not sure I like the proposed change in behavior to "shape". I personally do prefer the (perceived) amplitude increase when applying shape. I think traditional wave shaper effects in DAW's do not automatically lower the amplitude when applying shaping, but they often have a separate gain control to tame it, if desired.

On Mon, Nov 2, 2015 at 3:22 PM, Alex McLean notifications@github.com wrote:

Looks good! A little bit worried about the shape parameter change, a good idea but will change old patterns where people have compensated for the shape gain.. Should this be a commandline option too (with the new gain compensation being defaulted to on?) Or am I worrying too much?

— Reply to this email directly or view it on GitHub https://github.com/tidalcycles/Dirt/pull/41#issuecomment-153160902.

bgold-cosmos commented 9 years ago

Good points on the gain comp for shape - I included it since I find I always turn down gain when using shape, but not everyone is like me and it would break existing patterns. And it should be easy to make it a command-line option, so I'll try that out and update the pull request.