search

tidalcycles / Dirt

Experimental sample playback
GNU General Public License v3.0
85 stars 24 forks source link

Change `loop` to float #59

Closed bgold-cosmos closed 8 years ago

bgold-cosmos commented 8 years ago

loop was changed to a float for Tidal v0.9, which broke classic Dirt. I've created a new 0.9-dev branch in Dirt, and this commit fixes things, though Dirt doesn't (yet?) handle fractional loop in the same way.

If someone could help figure out how to get rid of the samples subfolder change, I'd be thankful. Git doesn't want to ignore it.

lennart commented 8 years ago

Hey @bgold-cosmos,

the change is legit since I guess you updated your local Dir-Samples submodule to the latest version (https://github.com/tidalcycles/Dirt-Samples/commit/69f0d8d5b13d553a789808fecd5bf974bbd5f089)

if of course you'd want to separate this bump of dependencies, you could just go into your local samples directory and checkout the original version.

otherwise you could also simply not stage the change, so that it won't end up in this pr (you'd have to rebase&&force-push or recreate the pr with a new branch)

However, I haven't yet read the actual changes in this pr...

kindly,

lennart