tidalcycles / Tidal

Pattern language
http://tidalcycles.org/
GNU General Public License v3.0
2.22k stars 254 forks source link

fix(slice): support `slice 1 _` #1086

Closed grddavies closed 3 months ago

grddavies commented 3 months ago

fixes: #979

Slice was failing on any slice pN of 1. This was because the begin of the next slice was being used to calculate the end of the first. With slice 1 _ all slices begin at 0.0, so end is incorrectly set to 0.0.

This implementation calculates the end control pattern by generating a sample-width pattern, and adding this to the begin pattern.

Two tests are added:

yaxu commented 3 months ago

Thanks!