tidalcycles / strudel

Web-based environment for live coding algorithmic patterns, incorporating a faithful port of TidalCycles to JavaScript
https://strudel.cc/
GNU Affero General Public License v3.0
579 stars 105 forks source link

github actions fails website postinstall task when hs2js is a workspace dependency #1106

Open felixroos opened 1 month ago

felixroos commented 1 month ago

follow up for https://github.com/tidalcycles/strudel/pull/870 see https://github.com/tidalcycles/strudel/pull/870#issuecomment-2119178225

when settings hs2js to "workspace:*", or when removing it and copying the wasm files from ../packages/tidal/node_modules/hs2js/dist/ .

in both cases, hs2js is a symlink, which probably somehow doesn't work in github actions. It works when using an older version of hs2js, forcing pnpm to not create a symlink. It should be noted that the dependency set in website is only for the tree-sitter wasm files. The actual hs2js logic will be up to date, so the dep only needs to be updated when hsj2s rebuilds the wasm files with a newer version of tree-sitter / tree-sitter-haskell.