tidalcycles / strudel

Web-based environment for live coding algorithmic patterns, incorporating a faithful port of TidalCycles to JavaScript
https://strudel.cc/
GNU Affero General Public License v3.0
641 stars 111 forks source link

remove redundant example for cat, update snapshot #1189

Closed kdiab closed 3 days ago

kdiab commented 1 week ago

This PR is for issue #1186

cat was documented twice causing it to appear twice in the API reference. This change removes the less descriptive example and keeps the other one.

image

felixroos commented 1 week ago

thanks for your contribution. It looks like this example you've removed is still referenced (as Pattern.cat) in https://strudel.cc/learn/factories/#cat , so maybe add it there as a MiniRepl instead?

kdiab commented 1 week ago

Yeah I think that's a good idea! This looks more informative.

image

kdiab commented 1 week ago

Found the same bug for seq and stack, going to combine with this PR. image image

felixroos commented 3 days ago

It looks like this example you've removed is still referenced (as Pattern.cat) in https://strudel.cc/learn/factories/#cat

have you looked at this? seq and stack might have refs as well

kdiab commented 3 days ago

Yes! That's where I got the examples from 😊

felixroos commented 3 days ago

i mean have you checked if the factories page still looks as before? for example, this reference: https://github.com/tidalcycles/strudel/blob/e409086b34c9a226e518a190ed86cc2510c640be/website/src/pages/learn/factories.mdx?plain=1#L38 just to double check

kdiab commented 3 days ago

Oh I understand what you mean, yes that does seem to break the page, I will fix it.

kdiab commented 3 days ago

Removed unnecessary instances of functions and fixed the factories folder.

image image image image image

felixroos commented 3 days ago

thanks, this now looks good!