search

tidalcycles / tidal-chocolatey

6 stars 5 forks source link

Move superdirt install to last step in case it hangs (short term work… #13

Open cleary opened 1 year ago

cleary commented 1 year ago

…around only)

Once superdirt has it's own package, we will need to make it more robust

ping @HighHarmonics2 @il-mix

HighHarmonics2 commented 1 year ago

Thanks @cleary for thinking of this. Once SuperDirt has its own package in Chocolatey, this change will be moot because we will remove the SuperDirt install steps from chocolateyinstall.ps1.

Also I don't think we should make this change now. My understanding is that the Chocolatey build step grabs the chocolateyinstall.ps1 at the time of build and thus the choco installer doesn't grab this file on each install. (@il-mix or @yaxu should confirm or correct me.) Adding this change would require submitting a new build of the Tidal Cycles package, which would then go through a round of review/approvals. Since we will do this anyway once the SuperDirt package is approved, it would complicate things to have multiple versions in review.

This change would have made sense during the last major change.

As always, I stand ready to be corrected!

il-mix commented 1 year ago

Side note. From my many test installing/disinstalling things via Chocolatey, I noticed that it processes the dependecies quite randomly. If they are chained, they follow an order, but otherwise they are random. As an example, Tidal depends on SuperCollider and SuperDirt, SuperDirt depends on SuperCollider => SuperCollider will be installed before SuperDirt. But Pulsar can be installed randomly between these packages (can be installed in parallel, too). Furthermore, once SuperDirt is a dependency, it will ALWAYS be installed before Tidal, so it can't be the last step. So yeah, we have to understand why it hangs sometime. In the meanwhile, @HighHarmonics2 can you add a troubleshoot entry that suggests to kill the orphan process in case of install hang? I'll try to replicate the problem so I can tell you the exact process name.

HighHarmonics2 commented 1 year ago

thanks for the detail @il-mix yes I can add a troubleshooting step for install hang

HighHarmonics2 commented 1 year ago

New troubleshooting step for SuperDirt hang provided in user docs: https://tidalcycles.org/docs/troubleshoot/troubleshoot_windows#superdirt-install-hangs-during-choco-install

@il-mix I don't think you need to provide the exact process name. I think it is OK to End Task on all running SuperCollider tasks in scide.

il-mix commented 1 year ago

Replicated SuperDirt install hang problem. The name of the orphan process is scsynth.exe. (Replicated on the first try. No good...)