search

tidalcycles / tidal-chocolatey

6 stars 5 forks source link

Amended the pathing of apmpath and quarkinstall.sc #6

Closed 444B closed 2 years ago

444B commented 2 years ago

tested on fresh windows 10 vm, ps1 script working all the way up to cabal install Need to continue testing on other fresh machines to verify that the pathing remains consistent and to continue troubleshooting of cabal updates

Changes:

  1. $apmpath: atom\bin was not listed as a directory, resulting in the binary not being located

  2. $quarkinstall_path: at time of testing, ChocolateyPackageFolder was not coming up as an environment variable despite being listed in the documentation Have resorted to using $env:ChocolateyInstall and have formatted the quarkinstall_path to be made with a ps Join-Path

444B commented 2 years ago

@yaxu Could you kindly review and provide feedback? This will allow me to continue fixing the choco installer

yaxu commented 2 years ago

Hi @444B, Thanks for the nudge, it would be great to improve the chocolatey install.

I'm not a windows user so can only be of so much help, but have made a couple of comments..

I don't know if @kindohm or @paulchannelstrip can give better comments. If you are up for working on and testing this then maybe it's better to give you write access to the repo etc.

yaxu commented 2 years ago

ChocolateyPackageFolder is indeed listed here: https://docs.chocolatey.org/en-us/create/functions/#variables

I wonder what's up with that..

444B commented 2 years ago

@yaxu Thank you, I would like to be more involved! I prefer Linux but my current setup dictates that windows will be the platform for me to use Tidal so naturally I am going to be very well acquainted with the issues going forward

I would be happy to test and work towards fixing the chocolatey install

yaxu commented 2 years ago

@444B Have you tried testing it with this? https://github.com/chocolatey-community/chocolatey-test-environment

You can also test locally with choco rather than running the ps1 scripts directly: https://community.chocolatey.org/courses/creating-chocolatey-packages/building-testing-and-pushing

444B commented 2 years ago

@yaxu Thank you for the resource sharing! Yes, this looks like a better approach. I will look into setting up the testing env this evening and document results

kindohm commented 2 years ago

I have no lib-bad/tidalcycles path on my local machine when installing TidalCycles. I don't fully understand what is going on, but I fear that hard-coding lib-bad would break the install for many users.