search

tidalcycles / tidal-listener

Experimental tidal OSC listener
GNU General Public License v3.0
16 stars 6 forks source link

Code highlight message structure typo #14

Open ndr-brt opened 3 years ago

ndr-brt commented 3 years ago

On the wiki it's reported that: < /code/highlight <duration> <cycle position> <row> <col> <row> <col>

but the reality is: < /code/highlight <duration> <cycle position> <col> <row> <col> <row>

In addition, row numbers start from 1 not from 0 as column numbers

yaxu commented 3 years ago

What do you think makes most sense - to match with x y ?

yaxu commented 3 years ago

Note also this idea: https://github.com/tidalcycles/tidal-listener/issues/9

Designed to make it easier to implement highlighting that works even as code is edited, as individual characters can be associated with the original tokens as they are highlighted.

ndr-brt commented 3 years ago

The best would be to match x y and make them starts from zero.