search

tidalcycles / tidal-midi

This package and method of using MIDI in Tidal is obsolete. Please use SuperDirt MIDI instead.
GNU General Public License v3.0
74 stars 36 forks source link

Korg Minilogue, Dave Smith Instruments Prophet 08 #35

Closed datesss closed 7 years ago

datesss commented 7 years ago

I don't super know how to do pull requests on github or how to program haskell, but i've been using these modules in my own music making for a few months now, if you want to incorporate them into the codebase. One thing that confused me is that the resonance will say its defined twice or not know which one to use when I load both modules before writing a .tidal song so i commented those out but maybe I shouldn't. Happy to change/update code/formatting and resubmit, just excited to contribute to an Open Source project :-D

kindohm commented 7 years ago

Thanks @datesss. Unfortunately the tidal-midi repository has gone through a lot of changes over the past couple of days and your PR is missing all the new code; we won't be able to merge. You'll need to sync your user's repository with the latest code in tidalcycles/tidal-midi, then commit and push your changes again. If you need some help with that, let me know.

yaxu commented 7 years ago

Yes + it'd be great if you could do this against the 1.0-dev branch rather than master. Please shout if you get stuck!