Add Vim8 Terminal support

flupe commented 4 years ago

As disccused in #38 , this PR adds support for the Vim8 Terminal feature. This allows the user to discard tmux entirely and have everything handled inside Vim. Before merging this PR, a few things need to be taken care of:

Further testing:
- [x] Works correctly with Vim8 terminal since I've tested it myself
However, we still need to check whether my code did not break the existing tmux solution nor the Neovim terminal feature.
- [ ] Tmux still supported
- [ ] Neovim terminal still supported
Perhaps we should change the wording of the README a bit. With native terminal support in both Neovim and Vim, I don't think we should emphasize tmux support this much --- we should explain how this plugin works with no dependencies, but that we have optional support for tmux as well. I actually changed the routine inside the code so that the native terminal feature is the default choice for the plugin. If a user wants to use tmux, they can effectively do:
```
let g:tidal_target = "tmux"
```
Likewise, since we now support native terminal for both Vim8 and Neovim, I think we should ditch the custom bash scripts altogether, or at the very least only refer to them in the tmux section. The installation should be as simple as possible, only requiring a simple
```
Plug "tidalcycles/vim-tidal"
```
Right now, having tmux as a dependency and requiring to run the makefile is too much.

That's all for now, I might think of other things later. Hope it's useful to some, don't hesitate to review, test or criticize the above.

flupe commented 4 years ago

@gmoe Thank you very much for taking the time to review my PR! I'll respond to your comments as I go about fixing them. I'm hoping to hear back from @munshkr as well.

munshkr commented 4 years ago

Hi @flupe ! Thank you for sending this PR. I agree with your proposal of making tmux optional, now that we have proper support of the terminal in both Vim 8 and Neovim. I'll test the tmux integration in a minute and comment if something else comes up.

mitchmindtree commented 2 years ago

This is looking great!

@flupe @munshkr could either of you give a summary of where this is at, or what work remains?

I love tmux, but this PR certainly seems like a much more conventional approach.

mitchmindtree commented 2 years ago

Thanks again for your work on this @flupe! Closing this PR as this work has landed as a part of #74.

tidalcycles / vim-tidal

Add Vim8 Terminal support #42