tidalcycles / vim-tidal

Vim plugin for TidalCycles
MIT License
222 stars 56 forks source link

flupe's vim8 terminal support - rebased onto master #74

Closed mitchmindtree closed 1 year ago

mitchmindtree commented 2 years ago

This rebases @flupe's work on implementing Vim 8 terminal support (#42) onto master.

Also removes mention of the not-yet-implemented :TidalStart command. I'll open separate issues for these.


I'm not yet savvy enough with VimL to review the rest of the changes here properly just yet, and I'm yet to actually test them locally :smiling_face_with_tear: Will report back once I get the chance.

@munshkr are you happy to remove tmux tiling support altogether in favour of native terminal support? I think it does make a lot of sense to encourage vim's native terminal instead as it skips the need for one extra 3rd party tool. I think it also avoids issues related to opening tmux inside of another instance of tmux (I'm almost always already inside a tmux pane :smile: ). Perhaps we can provide some handy tmux scripts/config under a separate tidalcycles repo?

munshkr commented 2 years ago

Hi @mitchmindtree thank for you reviving this! I think it makes a lot of sense to make the terminal mode the default and leave tmux as optional, for the reasons you mention. I wouldn't remove it completely, but it should definitely be optional, and we could provide instructions on how to enable it.

I'll review it and come back later today.

mitchmindtree commented 2 years ago

I have a follow-up commit here based on these changes that allows for specifying a custom BootTidal.hs path via g:boot_tidal, but I'll leave it for a follow-up PR to keep this one as small as possible.

mitchmindtree commented 2 years ago

Hey there @munshkr, would you be interested in some help with maintaining the plugin? I'd be happy to assist :bow:

mitchmindtree commented 1 year ago

Thanks again for adding me as a collaborator @munshkr :pray: Going to land this and start opening some new PRs for some pending work I have downstream.