search

tidb-challenge-program / bug-hunting-issue

Bug hunting issues.
3 stars 0 forks source link

P1-[4.0-bug-hunting]-[TiUP]- edit config (import from ansible) and reload not works #85

Open gekaiwen opened 4 years ago

gekaiwen commented 4 years ago

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. What did you do?

  1. deploy cluster by TiDB-ansible with default config 'oom-action'
  2. import TiDB cluster with TiUP
  3. edit config with TiUP, update 'oom-action' from 'log' to 'cancel' tiup cluster edit-config tidb-test -R tidb server_configs: tidb:
    oom-action: cancel
  4. reload config tiup cluster reload tidb-test -R tidb

2. What did you expect to see?

get tidb config by restAPI : "oom-action":"cancel"

3. What did you see instead?

get TiDB config by restAPI : "oom-action":"log" ; config in deploy dir '/data1/tidb/deploy/conf/tidb.toml' : "oom-action":"log" ; config in TiUP dir '/home/tidb/.tiup/storage/cluster/clusters/tidb-test/config/tidb-xxx-01-4200.toml' : "oom-action":"log"

4. What version of TiDB are you using? (tidb-server -V or run select tidb_version(); on TiDB)

tiup cluster -v Starting component cluster: /home/tidb/.tiup/components/cluster/v0.6.2/cluster -v tiup version v0.6.0 (Unknown/Unknown) go1.13

shuke987 commented 4 years ago

/bug P1

lonng commented 4 years ago

@gekaiwen Thanks for your feedback. This is a known issue that is caused by the wrong priority of overwriting configuration in cluster imported from Ansible.

We have submitted a PR to fix it. https://github.com/pingcap-incubator/tiup-cluster/pull/390