search

tidb-challenge-program / bug-hunting-issue

Bug hunting issues.
3 stars 0 forks source link

P2-[4.0-bug-hunting]-[TiUP]- edit config (import from ansible) leads to unexpect change #86

Open gekaiwen opened 4 years ago

gekaiwen commented 4 years ago

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. What did you do?

  1. deploy cluster by TiDB-ansible
  2. import TiDB cluster with TiUP
  3. edit config with TiUP, update any other value tiup cluster edit-config tidb-test -R tidb

2. What did you expect to see?

config which I updated change, others not change.

3. What did you see instead?

monitored: deploy_dir: deploy/monitor-9100 data_dir: data/monitor-9100 log_dir: deploy/monitor-9100/log

change to monitored: deploy_dir: deploy/monitor-9100 data_dir: data/monitor-9100 log_dir: deploy/monitor-9100/deploy/monitor-9100/log

4. What version of TiDB are you using? (tidb-server -V or run select tidb_version(); on TiDB)

tiup cluster -v Starting component cluster: /home/tidb/.tiup/components/cluster/v0.6.2/cluster -v tiup version v0.6.0 (Unknown/Unknown) go1.13

============================

https://github.com/pingcap-incubator/tiup-cluster/blob/master/pkg/meta/topology.go:618 maybe should add some check~

shuke987 commented 4 years ago

/bug P2

lonng commented 4 years ago

Fixed https://github.com/pingcap-incubator/tiup-cluster/pull/395