Closed shiyuhang0 closed 2 years ago
/run-all-tests
/run-all-tests
/run-all-tests
/run-all-tests
Since it's a performance-sensitive change. We need to add some benchmarks, maybe use jmh. https://jenkov.com/tutorials/java-performance/jmh.html https://github.com/apache/iceberg/tree/master/spark/v3.2/spark/src/jmh/java/org/apache/iceberg/spark
/run-all-tests
/run-all-tests
/run-all-tests
/run-all-tests
What is the purpose of the change
close #223
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
Documentation
JMH Test
jmh for TiDBRowConverter.toTiRow
before this pr:60 ns/op (bigint type)
in this pr:64 ns/op (int/tinyint/smallint/mudiumnint/year type)
jmh for convert object to long
(long)obj
Long.parseLong(obj.toString())
conclusion
Long.parseLong(obj.toString())
may have performance impact