tidbyt / community

A publishing platform for apps developed by the Tidbyt community 🚀
Apache License 2.0
379 stars 643 forks source link

Severe Weather app #2369

Closed GITHUB-139 closed 4 months ago

GITHUB-139 commented 5 months ago

Please updated font to tom-thumb, the selected font is hard to read, I loaded it locally, modified and pisplayed in pixlet serve, tom-thumb works good, and line not on top of each other.

    ## Main Alert Text
    mainAlertText = alert["properties"]["event"]

    mainAlertTextWrappedWidget = render.WrappedText(
        content = mainAlertText.upper(),
        align = "center",
        font = "tom-thumb",  # tiny
        color = "#FF0000",  # red
    )

See attacked zip webp from export on pixlet serve tidbyt-preview-1712115255238.webp.zip

GITHUB-139 commented 5 months ago

Cummunity app name: severewxalertsusa.star

jmanske commented 5 months ago

Might also be a solution to use the linespacing attribute in the WrappedText widget to make things a little more readable. Let's tag the app author @rs7q5 to see what he thinks!

rs7q5 commented 5 months ago

What is the original font?

I am not the original author. That would be @aschechter88. I don't think it's super hard to read (usually)and you also have to make sure to account for almost all scenarios or longer names. But I can see your point.

One possible option though that I don't think the author would care about would be to just add a simple font config of small/large texts (instead of all options). That I think would satisfy all parties. @jmanske is also right. Modifying line spacing may also help.

Can you post a before and after gif here just to see the difference, just out of curiosity.

Edit: words and a few extra clarifications.

GITHUB-139 commented 5 months ago

Original:CG-pixel-3x5-monoPROPOSED#tom-thumbThe spacing concerned mention is moot in irrevelent as in test unfact the tom-thumb actually is more efficient and will display more info so in yesterdays alerts with original: “FOG ADVISERY” on disply showed fog one first line adverisery on second line smoshed together  (Hence hard to read)  format 4x5x4x5x0 the proposed actually fit the full alert on line on (4x6x4x4x1) on the second alerts with was three lines on original font also three lines new font same three lines with one pixel space between the lines so gtheir not smashed together, I can only assume the author didnt set tom-thun oraginanly if it wasnt created yet as effectly they both will effectly only give 4 lines in the pane defined for the message.so to the other comment then sime if you want that original font fine allow font choice tom-thumb or the CG in the options, but realistically the cg3x5 is bad choice.Send from @. Apr 4, 2024, at 6:18 AM, rs7q5 @.> wrote: What is the original font? I am not the original author. That would be @aschechter88. I don't think it's super hard to read and you also have to make sure to account for almost all scenarios or longer names. One possible option though that I don't think the author would care about would be to just add a simple font config of small/large texts (instead of all options). That I think would satisfy all parties.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

jmanske commented 5 months ago

Setting linespacing = 1 on the WrappedText widget does fix the problem you are describing with the lines being too close together. Current state:

Screenshot 2024-04-05 at 5 19 37 AM

With linespacing = 1

Screenshot 2024-04-05 at 5 18 38 AM Screenshot 2024-04-05 at 5 24 06 AM Screenshot 2024-04-05 at 5 24 21 AM

Switching it to tom-thumb makes W, M, and N nearly indistinguishable from each other so I can understand why the developer may not have picked it. tom-thumb:

Screenshot 2024-04-05 at 5 26 09 AM Screenshot 2024-04-05 at 5 26 32 AM

If it were my app, my preference would be to leave the font the same and change the linespacing to 1.

GITHUB-139 commented 5 months ago

Ok, Let me try it locally setting the linespace, where did you put the linespace tag?  Net however, the code should be corrected, either way the best.  I’ll check how linespacing shows inn HDK later tonight.Send from @. Apr 5, 2024, at 5:28 AM, Jake Manske @.> wrote: Setting linespacing = 1 on the WrappedText widget does fix the problem you are describing with the lines being too close together. Current state: Screenshot.2024-04-05.at.5.19.37.AM.png (view on web) With linespacing = 1 Screenshot.2024-04-05.at.5.18.38.AM.png (view on web) Screenshot.2024-04-05.at.5.24.06.AM.png (view on web) Screenshot.2024-04-05.at.5.24.21.AM.png (view on web) Switching it to tom-thumb makes W, M, and N nearly indistinguishable from each other so I can understand why the developer may not have picked it. tom-thumb: Screenshot.2024-04-05.at.5.26.09.AM.png (view on web) Screenshot.2024-04-05.at.5.26.32.AM.png (view on web) If it were my app, my preference would be to leave the font the same and change the linespacing to 1.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

jmanske commented 5 months ago

It's in the same spot you changed the font in your first post. Instead of changing the font, add the linespacing attribute.

jmanske commented 5 months ago

I made a draft PR if you want to take a look. If you're good with it, I can submit it. #2376

stale[bot] commented 4 months ago

We're automatically closing this issue because it hasn't had any activity in 30 days. If that seems like a mistake, please feel free to re-open. Thanks!