search

tidbyt / community

A publishing platform for apps developed by the Tidbyt community 🚀
Apache License 2.0
398 stars 703 forks source link

Pull request review? #2492

Closed knauerhase closed 5 months ago

knauerhase commented 5 months ago

Hi. I wrote a simple app for Pride month and checked it in with a PR (#2491) last weekend. Do we need to ask anyone to look at it for approval, or do they just get around to it? @matslina is listed as an automatic reviewer.

jmanske commented 5 months ago

They will get around to it. They usually review them on Thursdays but sometimes it takes longer.

matslina commented 5 months ago

Hey. First of all, thanks for the PR. Second, apologies for the slow review time. Like @jmanske wrote we try to get through PRs once a week, but we've had a lot on our plates recently and are lagging behind.

matslina commented 5 months ago

Also: Happy Pride!

knauerhase commented 5 months ago

@matslina not a problem -- was just my first time through the process for this device.

Do approved apps go into the Tidbyt app for people to find? I just checked the app and it was there! Thanks!