Closed tpatel12 closed 1 month ago
⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀
Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Magical robots have reviewed your change and it looks good to go! 🤖 | Test | Details | |
---|---|---|---|
✅ | App Dir | All files are in a single app directory | |
✅ | Modules | Only safe modules, without side-effects, are loaded | |
✅ | Original Author | The original author matches the PR author |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA
recheck
Hi @tpatel12, just some friendly advice. Looks like you have a gradient_clock.star
file in the root of your fork. I believe the approach the Tidbyt team takes is to ensure that any community apps are only contributed in the /apps/<yourappname>
folders. I see that another contributor already has a gradient clock contributed to /apps/gradientclock
, so you will need to pick another app/folder name as to not override their community app. (e.g. /apps/gradientclock2
or some other equivalent)
Also, as a part of your app folder, let's say /apps/gradientclock2
, for example, you will need to also add a /apps/gradientclock2/manifest.yaml
file. Please follow documentation (or another app contributor's manifest file) to better understand how to create & format this file. 😊 If you have questions, please let me know and I can checkout your fork and make the revisions to show you.
Love the app BTW! 😁👏
Thanks for the advice @kaffolder7! I've restructured my project as you suggested, please let me know if anything else is needed!
Created a simple clock app with animated background gradient. Hope to publish!
I have read the CLA Document and I hereby sign the CLA.