Closed maxalines closed 4 months ago
⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀
Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for: | Test | Details | |
---|---|---|---|
✅ | App Dir | All files are in a single app directory | |
🟡 | Modules | Usage of animation.star requires review | |
✅ | Original Author | The original author matches the PR author |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA
recheck
@maxalines Most of the time when the CLA check isn't working, it's due to the email address associated with the commits not being registered under the Github account making the PR. Could that be the case here?
Hi @matslina - yes I think so! I submitted this PR (@maxalines) but the commit was done by @abdullahwaqar - we have both been working on this but @abdullahwaqar is the real developer here! Let me know if we need to do anything here.
Yeah I think the easiest path forward would be to either add that email address to the Github account (which seems a bit weird), or to update the email address on the commit itself (either via a new PR, or force pushing).
I have read the CLA Document and I hereby sign the CLA
Thanks!
The Synth Solar Monitoring app allows anyone who has solar inverters from particularly manufacturers (currently SolaX, Givenergy and Rahvolt - but many more to come!) to monitor their real time performance of their solar system in the Tidbyt app.
We are UK-based and primarily provide this for the customers we supply solar systems too, but we are happy to add anyone who has the inverters named above. The data is cleaned and normalised via our own server and API and so if you would like your inverter added please email as at hi@synth.solar and we can provide instructions on the information that we need from you to get it added.