Closed dinosaursrarr closed 2 weeks ago
⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀
Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for: | Test | Details | |
---|---|---|---|
✅ | App Dir | All files are in a single app directory | |
🟡 | Modules | Usage of http.star requires review | |
✅ | Original Author | The original author matches the PR author |
Looks like TfL have changed their response format. It used to provide details of the stop in the children attribute. Now, the relevant fields have been moved up to top-level fields, which is simpler.
Also being more tolerant of unknown bus stop letter codes.
Tested around my house (handful of top-level stops) and around King's Cross (many stops, nested within a hub).
Fixes https://github.com/tidbyt/community/issues/2656