search

tidbyt / community

A publishing platform for apps developed by the Tidbyt community 🚀
Apache License 2.0
398 stars 701 forks source link

.gitignore contains `.gif` #483

Closed kcharwood closed 2 years ago

kcharwood commented 2 years ago

I noticed the .gitignore file excludes .gif files.

https://github.com/tidbyt/community/blob/9fe098e091d00d692845f3096734aeb678c03175/.gitignore#L27

This was weird to me since the authoring instructions include a step to generate a screenshot with a README. However, the .gitignore prevents the screenshot from getting committed unless it is saved as a different file format type.

I would either remove from the .gitignore, or update the authoring instructions if there is a specific reason it was decided to ignore .gifs

rs7q5 commented 2 years ago

I believe the edition of the gif was a user mod to the readme. Fwiw, t's an optional step which I think the instructions say.

stale[bot] commented 2 years ago

We're automatically closing this issue because it hasn't had any activity in 30 days. If that seems like a mistake, please feel free to re-open. Thanks!