search

tiddlyhost / tiddlyhost-com

Rails application for creating and hosting TiddlyWiki sites, plus resources for deploying it to https://tiddlyhost.com/
Other
188 stars 18 forks source link

Investigate using the put.js saver instead of upload.js #148

Closed simonbaird closed 3 years ago

simonbaird commented 3 years ago

Suggested at https://github.com/Jermolene/TiddlyWiki5/pull/5622#issuecomment-825787480 .

simonbaird commented 3 years ago

https://github.com/Jermolene/TiddlyWiki5/blob/master/core/modules/savers/put.js

simonbaird commented 3 years ago

As per the commit message, saving works fine, but there's maybe some work needed on the error handling.

simonbaird commented 3 years ago

The link TW patch is intended to improve the error handling a little.

simonbaird commented 3 years ago

So I think it works fine, and long term I'd like to adopt it. In the short term though it's a small step backwards in usability due to the error handling. The PR linked above is an improvement, but I'd like to figure out a way to show a more user friendly error message on failure, which is something that the upload.js does now. Perhaps the solution will to create a dedicated saver, i.e. as suggested in #20, but the saver might end up being exactly the same code as the put saver, but with some Tiddlyhost specific error handling.

simonbaird commented 3 years ago

Investigation is done so let's close this. Will continue using the upload saver for now, but maybe a future tiddlyhost saver will be based on the put saver.