Simplify ThostUploadPlugin

tiddlyhost / tiddlyhost-com

Rails application for creating and hosting TiddlyWiki sites, plus resources for deploying it to https://tiddlyhost.com/

Other

184 stars 17 forks source link

Closed YakovL closed 7 months ago

YakovL commented 7 months ago

This suggests some preliminalry refactoring and fixes:

don't use with;
don't use a custom updateOriginal (added a hack for backward compatibility with versions below 2.9.2, but currently CoreVersion is set to 2.9.2 anyway);
don't duplicate metadata (well, I'd remove version.extensions.ThostUploadPlugin as well, but there's a tiny chance that somebody relies on the presence of it or version bits).

I'm planning more important updates, but let's handle this ones first.

simonbaird commented 7 months ago

Looks good to me. I gave the saving a quick test locally.

simonbaird commented 7 months ago

Thanks!

simonbaird commented 7 months ago

FYI I'm pushing out a build now, so you should see it on https://tiddlyhost.com/ in a minute or two.